Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues #41

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Fix type issues #41

merged 2 commits into from
Nov 10, 2019

Conversation

oyvinmar
Copy link
Contributor

  1. Removed types from package.json (it pointed to the wrong declaration file). Typescript should find index.d.ts automatically.
  2. AuthProvider need to return a JSX.Element (see [Question] JSX.Element vs React.ReactNode once again typescript-cheatsheets/react#129). It may be better to just type the props and let the rest be inferred.

@Swizec
Copy link
Owner

Swizec commented Nov 10, 2019

Thanks @oyvinmar! Great fix, I'm still pretty new to types in libraries :)

@Swizec Swizec merged commit d973efb into Swizec:master Nov 10, 2019
@Swizec
Copy link
Owner

Swizec commented Nov 10, 2019

@all-contributors add @oyvinmar for code

@allcontributors
Copy link
Contributor

@Swizec

I've put up a pull request to add @oyvinmar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants