Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
silentSyncLoadJsonFile()
can return undefined we should(?) nullguard theversions
variable.From what I understand it should be ok for the
versions
variable to be undefined.We have some repos whos travis builds is failing on this
For example when running mocha on Jalla
// Side-note the build-script won't finnish if one is missing theI see that its been failaing on this for a while so I revert my ignore editdist/rev dist/bare
folders. I changed the gitIgnore but you might want to do it a different way?