ShopBillingData on invoice show should be taken from channel #52
Labels
Bug
Confirmed bugs or bugfixes.
Comments
|
I would like to try to fix that if nobody is working. |
|
Hello Guillem! It's been a while, sorry about that - I haven't seen your comment so far. Of course, you can fix that if you would like to :) |
pamil
added a commit
to Sylius/Sylius
that referenced
this issue
Jan 10, 2019
This PR was merged into the 1.4-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | associated with Sylius/RefundPlugin#106, Sylius/InvoicingPlugin#52 | License | MIT During the development of `InvoicingPlugin`, we introduced a concept of shop billing data (set per channel) that is required to be displayed on an invoice. On the other hand, we also should have it in a `RefundPlugin` to generate a credit memo properly. We considered a few options, but in the end, it's quite a common use case to have such a bunch of data manageable in Admin panel. <img width="563" alt="zrzut ekranu 2019-01-9 o 11 04 31" src="https://user-images.githubusercontent.com/6212718/50892815-a35ed480-13ff-11e9-81e7-d5a96c6f8e28.png"> Commits ------- f7cdb55 Shop billing data on channel tests ea37635 ShopBillingData entity and Channel relation 1185ef8 Shop billing data in channel form 0848c16 Tests fixes and nullable fields 801247a PR review changes cfdca1e Change column names to fulfill conventions
pamil
added a commit
to Sylius/SyliusCoreBundle
that referenced
this issue
Jan 10, 2019
This PR was merged into the 1.4-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | associated with Sylius/RefundPlugin#106, Sylius/InvoicingPlugin#52 | License | MIT During the development of `InvoicingPlugin`, we introduced a concept of shop billing data (set per channel) that is required to be displayed on an invoice. On the other hand, we also should have it in a `RefundPlugin` to generate a credit memo properly. We considered a few options, but in the end, it's quite a common use case to have such a bunch of data manageable in Admin panel. <img width="563" alt="zrzut ekranu 2019-01-9 o 11 04 31" src="https://user-images.githubusercontent.com/6212718/50892815-a35ed480-13ff-11e9-81e7-d5a96c6f8e28.png"> Commits ------- f7cdb5522feec956a5964dbd97b444e89ea11448 Shop billing data on channel tests ea37635e60d9ff0bd47273978bbc6a3f3652cc75 ShopBillingData entity and Channel relation 1185ef8657c327190004e297be93e52c1ca05235 Shop billing data in channel form 0848c16074c707e57fa981fe7ae838c820e0f731 Tests fixes and nullable fields 801247abb80c5feaa357073987beb770a9a6eada PR review changes cfdca1e8363abf739f2a601021171d6f6a1d7dd1 Change column names to fulfill conventions
pamil
added a commit
to Sylius/Core
that referenced
this issue
Jan 10, 2019
This PR was merged into the 1.4-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | associated with Sylius/RefundPlugin#106, Sylius/InvoicingPlugin#52 | License | MIT During the development of `InvoicingPlugin`, we introduced a concept of shop billing data (set per channel) that is required to be displayed on an invoice. On the other hand, we also should have it in a `RefundPlugin` to generate a credit memo properly. We considered a few options, but in the end, it's quite a common use case to have such a bunch of data manageable in Admin panel. <img width="563" alt="zrzut ekranu 2019-01-9 o 11 04 31" src="https://user-images.githubusercontent.com/6212718/50892815-a35ed480-13ff-11e9-81e7-d5a96c6f8e28.png"> Commits ------- f7cdb5522feec956a5964dbd97b444e89ea11448 Shop billing data on channel tests ea37635e60d9ff0bd47273978bbc6a3f3652cc75 ShopBillingData entity and Channel relation 1185ef8657c327190004e297be93e52c1ca05235 Shop billing data in channel form 0848c16074c707e57fa981fe7ae838c820e0f731 Tests fixes and nullable fields 801247abb80c5feaa357073987beb770a9a6eada PR review changes cfdca1e8363abf739f2a601021171d6f6a1d7dd1 Change column names to fulfill conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now shop billing data is taken from
and should be
where channel should be taken from ChannelRepository using channelCode from InvoiceChannel
The text was updated successfully, but these errors were encountered: