-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hooks for product page #16594
Merged
Wojdylak
merged 8 commits into
Sylius:bootstrap-shop
from
bartek-sek:SYL-3678/product-page-hooks
Jul 25, 2024
Merged
Implement hooks for product page #16594
Wojdylak
merged 8 commits into
Sylius:bootstrap-shop
from
bartek-sek:SYL-3678/product-page-hooks
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
GSadee
reviewed
Jul 17, 2024
src/Sylius/Bundle/ShopBundle/templates/product/show/summary/catalog_promotions.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/main/images.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/main/accordion.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/main/accordion/attributes.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/summary/add_to_cart.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/summary/price.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/templates/product/show/summary/price.html.twig
Outdated
Show resolved
Hide resolved
67faa3d
to
1124ddf
Compare
Wojdylak
reviewed
Jul 24, 2024
src/Sylius/Bundle/ShopBundle/Resources/config/app/twig_hooks/product/show.yaml
Outdated
Show resolved
Hide resolved
...lius/Bundle/ShopBundle/templates/product/show/page/info/summary/catalog_promotions.html.twig
Outdated
Show resolved
Hide resolved
...plates/product/show/page/info/summary/variant_selection/add_to_cart/variants/table.html.twig
Outdated
Show resolved
Hide resolved
1124ddf
to
9276076
Compare
mpysiak
approved these changes
Jul 25, 2024
Wojdylak
approved these changes
Jul 25, 2024
{{ variant.name|default(variant.descriptor) }} | ||
{% if product.hasOptions() %} | ||
<div> | ||
{% for optionValue in variant.optionValues %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
{% for optionValue in variant.optionValues %} | |
{% for option_value in variant.optionValues %} |
Wojdylak
added a commit
that referenced
this pull request
Jul 30, 2024
This PR should be merged after #16594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.