Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hooks for product page #16594

Merged

Conversation

bartek-sek
Copy link
Contributor

No description provided.

@bartek-sek bartek-sek requested review from a team as code owners July 17, 2024 10:19
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@bartek-sek bartek-sek force-pushed the SYL-3678/product-page-hooks branch from 67faa3d to 1124ddf Compare July 22, 2024 11:34
@bartek-sek bartek-sek force-pushed the SYL-3678/product-page-hooks branch from 1124ddf to 9276076 Compare July 25, 2024 07:52
{{ variant.name|default(variant.descriptor) }}
{% if product.hasOptions() %}
<div>
{% for optionValue in variant.optionValues %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% for optionValue in variant.optionValues %}
{% for option_value in variant.optionValues %}

@Wojdylak Wojdylak merged commit 605d965 into Sylius:bootstrap-shop Jul 25, 2024
19 checks passed
Wojdylak added a commit that referenced this pull request Jul 30, 2024
This PR should be merged after #16594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants