Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Fix data grid sorting when there are no defaults #16839

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Sep 3, 2024

Q A
Branch? 2.0
Bug fix? yes (on 2.0, but I think we also have this issue in 1.x)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

When there is no default sorting (see below), the sorting link doesn't work.

sylius_grid:
    grids:
        sylius_admin_product:
            driver:
                name: doctrine/orm
                options:
                    class: "%sylius.model.product.class%"
                    repository:
                        method: createListQueryBuilder
                        arguments: ["expr:service('sylius.context.locale').getLocaleCode()"]
#            sorting:
#                code: asc

Before
Capture vidéo du 2024-09-03 10-43-21.webm

After
Capture vidéo du 2024-09-03 10-44-41.webm

@loic425 loic425 requested review from a team as code owners September 3, 2024 08:49
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@loic425 loic425 changed the title Fix data grid sorting when there are no defaults [2.0] Fix data grid sorting when there are no defaults Sep 4, 2024
Copy link
Contributor

@Roshyo Roshyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought it was intended behaviour 😆 Thanks

@GSadee GSadee merged commit 04b222c into Sylius:2.0 Sep 4, 2024
19 checks passed
@loic425 loic425 deleted the fix/sorting-when-there-are-no-defaults branch September 4, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants