Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NaN checks by default #2

Closed
MilesCranmer opened this issue Oct 18, 2022 · 0 comments · Fixed by #5
Closed

Remove NaN checks by default #2

MilesCranmer opened this issue Oct 18, 2022 · 0 comments · Fixed by #5

Comments

@MilesCranmer
Copy link
Member

Right now, NaN and Inf checks are performed throughout the evaluation code. This is tied to SymbolicRegression.jl, but isn't needed in other cases, and slows them down a bit. Thus, I think eval_tree_array and related functions should have a flag for performing NaN and Inf checks or not.
@MilesCranmer MilesCranmer linked a pull request Oct 21, 2022 that will close this issue
By default, throw errors from MethodError #5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

By default, throw errors from MethodError SymbolicML/DynamicExpressions.jl
1 participant
@MilesCranmer