By default, throw errors from MethodError
#5
+107
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, in
eval_tree_array(::Node, ::AbstractArray, ::GenericOperatorEnum)
,MethodError
s are caught before they occur, and nothing is returned. This is faster, but may not be what a user expects.This introduces a new keyword argument
throw_error
toeval_tree_array
(only the generic version) which can be turned on (default) to throwMethodError
s, or off, to cleanly catch them and return nothing. In practice, it can be faster to simply return early, rather than to throw and catch an error.