Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-finite .val evaluation issue #110

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

MilesCranmer
Copy link
Member

Should fix MilesCranmer/PySR#759 by @GoldenGoldy

This also includes a test that randomly generates trees and fills their .val with Inf or NaN. This test failed before this fix (which is bad!) but now passes.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12141411622

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.32%

Totals Coverage Status
Change from base Build 11733401928: 0.0%
Covered Lines: 2424
Relevant Lines: 2543

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit c73a705 into master Dec 3, 2024
13 checks passed
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Benchmark Results

master a035f4b... master/a035f4bfcb2cce...
eval/ComplexF32/evaluation 7.32 ± 0.58 ms 7.24 ± 0.6 ms 1.01
eval/ComplexF64/evaluation 10.8 ± 0.98 ms 10.7 ± 0.85 ms 1.01
eval/Float32/derivative 11.7 ± 1 ms 11.6 ± 1.1 ms 1.01
eval/Float32/derivative_turbo 11.7 ± 1.1 ms 11.6 ± 1.1 ms 1.01
eval/Float32/evaluation 2.79 ± 0.27 ms 2.77 ± 0.25 ms 1.01
eval/Float32/evaluation_bumper 0.609 ± 0.015 ms 0.607 ± 0.015 ms 1
eval/Float32/evaluation_turbo 0.573 ± 0.034 ms 0.566 ± 0.036 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.61 ± 0.014 ms 0.608 ± 0.015 ms 1
eval/Float64/derivative 15.2 ± 0.77 ms 15.5 ± 0.96 ms 0.98
eval/Float64/derivative_turbo 15 ± 0.64 ms 14.9 ± 0.63 ms 1.01
eval/Float64/evaluation 3.21 ± 0.32 ms 3.17 ± 0.32 ms 1.01
eval/Float64/evaluation_bumper 1.26 ± 0.044 ms 1.27 ± 0.048 ms 0.993
eval/Float64/evaluation_turbo 1.05 ± 0.071 ms 1.05 ± 0.07 ms 1
eval/Float64/evaluation_turbo_bumper 1.26 ± 0.046 ms 1.27 ± 0.046 ms 0.995
utils/combine_operators/break_sharing 0.0386 ± 0.00068 ms 0.0386 ± 0.0006 ms 0.999
utils/convert/break_sharing 27.7 ± 2.8 μs 26.9 ± 2.5 μs 1.03
utils/convert/preserve_sharing 0.0988 ± 0.0042 ms 0.0986 ± 0.0042 ms 1
utils/copy/break_sharing 28 ± 2.5 μs 27.6 ± 2.6 μs 1.01
utils/copy/preserve_sharing 0.0994 ± 0.0045 ms 0.1 ± 0.0042 ms 0.991
utils/count_constant_nodes/break_sharing 8.88 ± 0.22 μs 8.34 ± 0.21 μs 1.06
utils/count_constant_nodes/preserve_sharing 0.0862 ± 0.0033 ms 0.0836 ± 0.0036 ms 1.03
utils/count_depth/break_sharing 9.57 ± 0.23 μs 9.86 ± 0.26 μs 0.972
utils/count_nodes/break_sharing 8.44 ± 0.2 μs 8.59 ± 0.2 μs 0.983
utils/count_nodes/preserve_sharing 0.085 ± 0.0032 ms 0.0856 ± 0.0034 ms 0.992
utils/get_set_constants!/break_sharing 0.0329 ± 0.0024 ms 0.0341 ± 0.0022 ms 0.964
utils/get_set_constants!/preserve_sharing 0.179 ± 0.0069 ms 0.178 ± 0.0061 ms 1
utils/get_set_constants_parametric 0.0448 ± 0.0029 ms 0.0443 ± 0.0024 ms 1.01
utils/has_constants/break_sharing 4.1 ± 0.15 μs 4.24 ± 0.14 μs 0.967
utils/has_operators/break_sharing 1.96 ± 0.069 μs 2.26 ± 0.063 μs 0.87
utils/hash/break_sharing 22.6 ± 0.67 μs 22.9 ± 1 μs 0.986
utils/hash/preserve_sharing 0.0973 ± 0.0039 ms 0.0972 ± 0.0039 ms 1
utils/index_constant_nodes/break_sharing 24.6 ± 1.1 μs 25.2 ± 0.89 μs 0.977
utils/index_constant_nodes/preserve_sharing 0.0991 ± 0.004 ms 0.0998 ± 0.0039 ms 0.993
utils/is_constant/break_sharing 4.42 ± 0.16 μs 3.83 ± 0.14 μs 1.15
utils/simplify_tree/break_sharing 0.179 ± 0.0033 ms 0.166 ± 0.0032 ms 1.08
utils/simplify_tree/preserve_sharing 0.231 ± 0.0063 ms 0.217 ± 0.0062 ms 1.06
utils/string_tree/break_sharing 0.468 ± 0.017 ms 0.464 ± 0.018 ms 1.01
utils/string_tree/preserve_sharing 0.576 ± 0.026 ms 0.576 ± 0.02 ms 1
time_to_load 0.239 ± 0.0019 s 0.233 ± 0.0031 s 1.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Getting some "juliacall.JuliaError" errors since the update to v1.0.0
1 participant