Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-place copy for trees #113

Merged
merged 3 commits into from
Dec 12, 2024
Merged

in-place copy for trees #113

merged 3 commits into from
Dec 12, 2024

Conversation

MilesCranmer
Copy link
Member

Should also help bring down GC allocations in combination with #112

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12288201527

Details

  • 44 of 47 (93.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on reduce-allocs at 95.374%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ParametricExpression.jl 10 13 76.92%
Totals Coverage Status
Change from base Build 12287719693: 95.4%
Covered Lines: 2515
Relevant Lines: 2637

💛 - Coveralls

Copy link
Contributor

Benchmark Results

master 2268896... master/22688966ea334f...
eval/ComplexF32/evaluation 7.22 ± 0.51 ms 7.22 ± 0.56 ms 1
eval/ComplexF64/evaluation 10.6 ± 0.84 ms 10.6 ± 0.78 ms 1
eval/Float32/derivative 11.5 ± 0.99 ms 11.5 ± 0.83 ms 0.995
eval/Float32/derivative_turbo 11.4 ± 0.99 ms 11.5 ± 0.92 ms 0.99
eval/Float32/evaluation 2.71 ± 0.26 ms 2.7 ± 0.25 ms 1
eval/Float32/evaluation_bumper 0.573 ± 0.014 ms 0.57 ± 0.014 ms 1
eval/Float32/evaluation_turbo 0.54 ± 0.033 ms 0.536 ± 0.031 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.573 ± 0.014 ms 0.572 ± 0.013 ms 1
eval/Float64/derivative 15.5 ± 1.1 ms 14.4 ± 0.53 ms 1.07
eval/Float64/derivative_turbo 15.1 ± 0.84 ms 14.4 ± 0.57 ms 1.05
eval/Float64/evaluation 3.17 ± 0.3 ms 3.12 ± 0.32 ms 1.01
eval/Float64/evaluation_bumper 1.18 ± 0.042 ms 1.18 ± 0.045 ms 1
eval/Float64/evaluation_turbo 1.02 ± 0.071 ms 1.01 ± 0.065 ms 1.01
eval/Float64/evaluation_turbo_bumper 1.19 ± 0.042 ms 1.18 ± 0.044 ms 1.01
utils/combine_operators/break_sharing 0.0386 ± 0.00045 ms 0.0391 ± 0.00051 ms 0.986
utils/convert/break_sharing 27.3 ± 2.3 μs 26.4 ± 2.1 μs 1.03
utils/convert/preserve_sharing 0.0979 ± 0.0039 ms 0.0985 ± 0.0042 ms 0.994
utils/copy/break_sharing 27.7 ± 2.3 μs 27.3 ± 2.4 μs 1.02
utils/copy/preserve_sharing 0.0974 ± 0.0035 ms 0.0985 ± 0.004 ms 0.989
utils/count_constant_nodes/break_sharing 8.81 ± 0.21 μs 8.86 ± 0.19 μs 0.994
utils/count_constant_nodes/preserve_sharing 0.085 ± 0.003 ms 0.0867 ± 0.0033 ms 0.98
utils/count_depth/break_sharing 9.6 ± 0.21 μs 9.77 ± 0.25 μs 0.984
utils/count_nodes/break_sharing 8.19 ± 0.19 μs 8.3 ± 0.19 μs 0.986
utils/count_nodes/preserve_sharing 0.0853 ± 0.0036 ms 0.0856 ± 0.0034 ms 0.997
utils/get_set_constants!/break_sharing 0.0327 ± 0.0028 ms 0.0333 ± 0.0021 ms 0.98
utils/get_set_constants!/preserve_sharing 0.173 ± 0.0049 ms 0.177 ± 0.0053 ms 0.981
utils/get_set_constants_parametric 0.0442 ± 0.0025 ms 0.0447 ± 0.0022 ms 0.988
utils/has_constants/break_sharing 4.22 ± 0.12 μs 4.12 ± 0.14 μs 1.02
utils/has_operators/break_sharing 2.03 ± 0.071 μs 2 ± 0.075 μs 1.01
utils/hash/break_sharing 22.5 ± 0.93 μs 23 ± 0.54 μs 0.977
utils/hash/preserve_sharing 0.0967 ± 0.0032 ms 0.0973 ± 0.0036 ms 0.994
utils/index_constant_nodes/break_sharing 25.2 ± 0.95 μs 25.3 ± 1 μs 0.995
utils/index_constant_nodes/preserve_sharing 0.0971 ± 0.0031 ms 0.0994 ± 0.0039 ms 0.977
utils/is_constant/break_sharing 4.95 ± 0.12 μs 4.51 ± 0.12 μs 1.1
utils/simplify_tree/break_sharing 0.173 ± 0.0031 ms 0.171 ± 0.0028 ms 1.01
utils/simplify_tree/preserve_sharing 0.222 ± 0.0048 ms 0.226 ± 0.0069 ms 0.983
utils/string_tree/break_sharing 0.451 ± 0.012 ms 0.454 ± 0.016 ms 0.993
utils/string_tree/preserve_sharing 0.561 ± 0.018 ms 0.568 ± 0.023 ms 0.988
time_to_load 0.229 ± 0.0059 s 0.229 ± 0.0041 s 1

@MilesCranmer MilesCranmer merged commit 5e6482d into master Dec 12, 2024
14 checks passed
@MilesCranmer MilesCranmer deleted the reduce-allocs branch December 12, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants