Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information for additional inclusion of paths to search classes in #67

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

DocFX
Copy link
Contributor

@DocFX DocFX commented Oct 13, 2024

Update index.rst to add an example of additional paths to search, like the Twig Bridge provided Tailwind 2 form themes.

Update index.rst to add an example of additional paths to search, like the Twig Bridge provided Tailwind 2 form themes.
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, thanks for improving the docs!

I left some comments, DYT?

@@ -181,6 +181,31 @@ This represents the Tailwind configuration file:
symfonycasts_tailwind:
config_file: 'tailwind.config.js'

If you include any other files containing classes to be detected outside the
default directories, like the `form themes provided with the Twig Bridge component <https://github.com/symfony/symfony/blob/HEAD/src/Symfony/Bridge/Twig/Resources/views/Form/tailwind_2_layout.html.twig/>`_,
untouched from the ``vendor`` directory, for instance, after changing your Twig configuration like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
untouched from the ``vendor`` directory, for instance, after changing your Twig configuration like this:
from the untouched ``vendor/`` directory, after changing your Twig configuration like this:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My English might be deficient here: I thought the first one means "didn't copy/paste it in your project from vendor".

Second one seems to mean "not altering the vendor directory", which is by definition.

DocFX and others added 2 commits October 14, 2024 20:38
@bocharsky-bw
Copy link
Member

Thank you for improving the docs!

@bocharsky-bw bocharsky-bw merged commit 27a0ba0 into SymfonyCasts:main Oct 15, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants