Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels #296

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Channels #296

merged 4 commits into from
Oct 25, 2018

Conversation

jonny22094
Copy link
Contributor

No description provided.

@jonny22094 jonny22094 self-assigned this Oct 23, 2018
@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #296 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   38.47%   38.53%   +0.05%     
==========================================
  Files          88       99      +11     
  Lines        2773     4248    +1475     
  Branches        6        6              
==========================================
+ Hits         1067     1637     +570     
- Misses       1706     2611     +905

@@ -9,6 +9,7 @@
- [Install Socket from NPM](/project/install-from-npm)
- Building your own Sockets
- [Basics](/building-sockets/basics)
- [Channels](/building-sockets/channels)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it Real-time channels. (Please correct it everywhere to Real-time).

@@ -0,0 +1,118 @@
# Channels

Listen on Syncano Realtime Channels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add here a little bit description why and what for to use Channels.

@mkucharz mkucharz requested review from ksyhoo and removed request for Idered and maciejkorsan October 25, 2018 13:59
@mkucharz mkucharz merged commit 21070c9 into master Oct 25, 2018
@mkucharz mkucharz deleted the feat/channels_docs branch October 25, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants