-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl not working when running syncplay with iina or mpv #379
Comments
Not being a Mac users I can't provide much support. I know on some platforms an issue can (or used to) occur if you open a file with Syncplay because that changes the PATH (base location) and so it looks for YTDL in the wrong place. How are you running Syncplay? |
As a workaround you might be able to put something along the files of the following in mpv.conf (with the path being the relevant path to youtube-dl): If that works then let me know what worked. |
Tried adding the path in mpv.conf, didn't work unfortunately. I run Syncplay by opening it from Applications? I installed it via Homebrew (though it's the same downloading the dmg). |
My gut says we are witnessing c07206c on steroids, a.k.a. we are mixing two Python interpreters compiled for two architectures (x86_64 in the Syncplay app and aarch64 in the system provided one used by youtube-dl). How did you install youtube-dl? Did you use the version of Homebrew for x86_64 or for aarch64? Additionally, if you could open Terminal, run this command:
and report the result here, you could definitely help us. (What does that do, you might ask? It finds youtube-dl in your system, asks which interpreter it uses to run, asks the same interpreter for which architecture it was compiled for). |
Oh, I get it. I run Homebrew natively, so in terminal for youtube-dl I got:
I guess I'll need an x86_64 version for Syncplay? In case it's relevant, my mpv is arm, while iina is still Intel |
You would actually need an arm64 version of Syncplay, but... there is none 😦 (see #368) I guess we now need to think about how we can try to solve/mitigate this on our side. Thanks for reporting this and for your help. |
So, after a detailed investigation it seem that the CPU architecture might have nothing to do with this. I attempted a fix and pushed it on this repository, you can find the updated prerelease dmg in the action artifacts here: "direct" download (if that does not work, go to the job page and scroll down to find the artifacts, including the dmg). @cordelac We would really appreciate if you could download this dmg, test it on your system, and report here the results. For the moment, Side note: you might have to right click the executable twice before getting the Open button in the dialog... thanks, Apple. |
Just tested on the linked 1.6.8, not working unfortunately. Still getting
Appears to be acting as the same as it does in 1.6.7. If I can be of any further help, let me know |
Ok, it might be that there were more errors on top of each other... Since we are here, could you help us by retrieving a debug log from your system with the prerelease version that you just downloaded? Here is how you can do so:
Thanks again for your help! |
Okay, followed your instructions and got this:
|
I forgot that Homebrew on ARM has a different default prefix... Just to confirm, could you post here the result of Assuming that I got this right, I prepared another test build for you: direct download | build. Could you download the updated DMG from here and try again? If it still fails, I would also appreciate the updated debug log taken as described before. Thank you again! |
The result is and the latest version you prepared is working! Tested on iina (Intel) just in case, and it's also working great, thanks! |
@albertosottile @cordelac Sadly the build link has been expired. Is there a binary for Apple Silicon M1 available somewhere else? |
@tristan-k The binary posted here was never an Apple Silicon binary, but merely a fix for |
URL's aren't working when running syncplay with iina or mpv.
However, URL's on both players work fine when outside syncplay. Tested with random youtube links.
OS - Big Sur 11.1 on M1
Syncplay: 1.6.7
youtube-dl: 2021.1.16
mpv: 0.33.0 // iina: 1.1.2 build 128
The text was updated successfully, but these errors were encountered: