Bidder user sync configs #2
Conversation
There was a problem hiding this comment.
I found some user syncers without userSync urls:
That's fine. We no longer require code to enable user syncing for adapters. Hosts which configure user syncing for these adapters will need to update their config to keep them working since we loose information on the sync type. I'm not sure if that's a big deal.
static/bidder-info/appnexus.yaml
Outdated
| key: "adnxs" | ||
| redirect: | ||
| url: "https://ib.adnxs.com/getuid?{{.RedirectURL}}" | ||
| userMacro: "$UID" |
There was a problem hiding this comment.
This is the correct content. The key and redirect fields need to exist on the same indentation level:
userSync:
key: "adnxs"
redirect:
url: "https://ib.adnxs.com/getuid?{{.RedirectURL}}"
userMacro: "$UID"
There was a problem hiding this comment.
Fixed. I also checked other "keys" - this is the only one case with wrong formatting
The AMX adapter looks to have strange behavior. I've email them to work through it. The others append the uid to the end of the redirect url instead of using a macro. I'll add a note to the default redirect url mentioning this important behavior. I think that's better than copying the redirect url template to each of these adapters, although it would prevent accidental breaking changes in the future. What do you think? We could also add a comment to these adapters too, something like: or something like this with the user macro omitted: |
static/bidder-info/lockerdome.yaml
Outdated
| userSync: | ||
| redirect: | ||
| url: "https://lockerdome.com/usync/prebidserver?pid="+cfg.Adapters["lockerdome"].PlatformID+"&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}" | ||
| userMacro: "{{uid}}" |
There was a problem hiding this comment.
The LockerDome adapter is using the PlatformID in an unintended way. I suggest we comment out their userSync and add a comment:
# lockerdome requires a platform id for their user sync process. replace <<PlatformID>>
# in the url below and uncomment the userSync section to enable.
#
#userSync:
# redirect:
# url: "https://lockerdome.com/usync/prebidserver?pid=<<PlatformID>>&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}"
# userMacro: "{{uid}}"
There was a problem hiding this comment.
Modified content to comment.
I left comments for adnxs and lockerdome. The others look correct. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sorry I closed it accidentally, changed it back to "Open" |
^ Added a comment at the end of file for syncers with empty |
@SyntaxNode
Added bidder user sync configs.
I found some user syncers without userSync urls:
Also there are some configs where userMacro is empty:
"amx"
"connectad"
"consumable"
"conversant"
"gumgum"
"ix"
"pubmatic"
Please double check next configs, not sure about url:
"adnxs"
"grid"
"lockerdome" -> don;'t know about what url should be in this case
"trustx"