Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Expo SDK 52 #593

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Updates to Expo SDK 52 #593

merged 4 commits into from
Feb 4, 2025

Conversation

LucientZ
Copy link
Collaborator

This PR updates various packages for Expo SDK 52. This needs some testing on IOS in order to ensure compatability.

There is a warning that says process.env.EXPO_OS is not defined, but this can be fixed by defining it in .env. The variable doesn't actually seem to affect much, but it's nice to have it defined anyways.

@LucientZ LucientZ linked an issue Jan 31, 2025 that may be closed by this pull request
@LucientZ LucientZ requested a review from JasonIsAzn January 31, 2025 17:44
@JasonIsAzn
Copy link
Member

JasonIsAzn commented Feb 1, 2025

I found a few bugs [HAVE BEEN FIXED NOW]:

I'll do more testing for this PR just to make sure we find most of the bugs

@JasonIsAzn
Copy link
Member

JasonIsAzn commented Feb 1, 2025

react-native-maps/react-native-maps#5206 (comment)

React Native Map does not support the react new-arch, so maybe we should disable this until it gets fixed
"newArchEnabled": true,

[update] doing some testing there does not seem to be a problem. so maybe i'm worried for nothing

@LucientZ
Copy link
Collaborator Author

LucientZ commented Feb 1, 2025

I'll test on my end as well since it may be different on Android. If need be, we can hold back until Monday to actually discuss whether we really want to upgrade to SDK 52 or just do minor package security updates.

@mestrada03 mestrada03 self-requested a review February 4, 2025 01:47
Copy link
Collaborator

@mestrada03 mestrada03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LucientZ LucientZ merged commit 167438c into dev Feb 4, 2025
1 check passed
@LucientZ LucientZ deleted the package-updates branch February 4, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Expo SDK packages
3 participants