better way to display video downloads #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switching back to HQ MKV/Compat MP4 like old site had, except new pubs only have the latter fix #1704
adelikat
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching back to HQ MKV/Compat MP4 like old site had, except new pubs only have the latter.
There are few cases when an MKV is 512kb (encoded using streamable presets so it's not HQ, but neither is it streamable due to container) to put .ass subtitles in there. I think it's no big deal if we still automatically call them HQ MKV in the GUI, just because having to add exceptions for those would complicate things for little benefit, and .ass is technically higher quality subtitle than .srt (not in terms of resolution but in terms of other traits), and MKV is still not as compatible anyway.
fix #1704