CSP round 3(?) #2003
Merged
CSP round 3(?) #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelikat
reviewed
Oct 8, 2024
TASVideos/Pages/Diagnostics/UserAgentInterventionReports.cshtml.cs
Outdated
Show resolved
Hide resolved
TASVideos/Pages/Diagnostics/UserAgentInterventionReports.cshtml
Outdated
Show resolved
Hide resolved
|
Oh I see, you want an endpoint that can be called that can then track requests and report statistics? How about not do that one right now, that's a huge lift and needs to be carefully planned as to where and how it will be stored and reported |
YoshiRulz
commented
Oct 9, 2024
|
inject an AppSettings object and there is a BaseUrl property in there |
YoshiRulz
force-pushed
the
csp-round-3-maybe
branch
from
ddd5ebf to
4e28e82
Compare
|
Rebased, moving all the reporting stuff to a third commit which is |
adelikat
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
default-srcandrequire-trusted-types-fordirectives to pass Google's tester, plus the directivesfont-src,frame-src, andimg-srcsince they'd otherwise fall back todefault-srcand that's now too strict. Also adds the unrelatedbase-uriandform-actiondirectives just because it's a good idea.