Allow case-renaming Users #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, we couldn't rename users from "CoolDude" into "cooldude" because we did the check case insensitively. If we carelessly allowed it, then someone could be renamed into "Adelikat" when "adelikat" already exists.
This PR changes this so that both cases are now properly handled. The critical line is
.Where(userName => userName == oldUserName || userName == newUserName)We ourselves don't check anything with letter case, and instead we let the DB do everything. We use it to check for both the old user name and the new one, and if the DB finds 2 different people, then we can't rename.
Also there are unit tests. :D