Merge pull request microsoft#983 from dcantah/breakway-job

Set CREATE_BREAKAWAY_FROM_JOB flag for job container processes
TBBle · Mar 25, 2021 · 77f39d6 · 77f39d6
2 parents 29393c5 + bb94c35
commit 77f39d6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/jobcontainers/jobcontainer.go b/internal/jobcontainers/jobcontainer.go
@@ -218,7 +218,9 @@ func (c *JobContainer) CreateProcess(ctx context.Context, config interface{}) (_
 		Path: absPath,
 		Args: splitArgs(commandLine),
 		SysProcAttr: &syscall.SysProcAttr{
-			CreationFlags: windows.CREATE_NEW_PROCESS_GROUP,
+			// CREATE_BREAKAWAY_FROM_JOB to make sure that we're not inheriting the job object (and by extension its limits)
+			// from whatever process is running this code.
+			CreationFlags: windows.CREATE_NEW_PROCESS_GROUP | windows.CREATE_BREAKAWAY_FROM_JOB,
 			Token:         syscall.Token(token),
 		},
 	}