Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat calibration fixes #106

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

paolomassa
Copy link
Contributor

  • Implemented background subtraction in the demo
  • Fixed ELUT correction
  • Implemented ELUT correction for background counts
  • Implemented Energy Edge Masks

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.47%. Comparing base (d44a1c8) to head (b88fdb5).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/map/stix.py 14.28% 6 Missing ⚠️
stixpy/calibration/visibility.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   66.33%   68.47%   +2.13%     
==========================================
  Files          31       31              
  Lines        1821     1843      +22     
==========================================
+ Hits         1208     1262      +54     
+ Misses        613      581      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney samaloney force-pushed the feat-calibration-fixes branch from e2c75f6 to d4926e2 Compare May 3, 2024 14:55
samaloney and others added 4 commits May 3, 2024 21:48
- Implemented ELUT correction for count erros
- Defined Energy Edge Masks
- Implemented backround subtraction in the demo
@samaloney samaloney force-pushed the feat-calibration-fixes branch from d4926e2 to b88fdb5 Compare May 3, 2024 20:48
@samaloney samaloney merged commit a35a42c into TCDSolar:main May 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants