Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to irregularly rebin data in N dimensions (Part 2) #120

Closed
wants to merge 24 commits into from

Conversation

DanRyanIrish
Copy link
Contributor

@DanRyanIrish DanRyanIrish commented May 20, 2024

This PR continues #109. It tries to create a function that can irregularly rebin an NDCube instance.

To Do

  • Update tests, including adding test for rebinned WCS.
  • Add changelog

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 92.39130% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.62%. Comparing base (a694ede) to head (95a4da3).
Report is 13 commits behind head on main.

Files Patch % Lines
stixpy/product/tools.py 87.75% 12 Missing ⚠️
stixpy/coordinates/transforms.py 97.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   68.92%   73.62%   +4.70%     
==========================================
  Files          31       32       +1     
  Lines        1847     2252     +405     
==========================================
+ Hits         1273     1658     +385     
- Misses        574      594      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanRyanIrish DanRyanIrish changed the title WIP: Add function to irregularly rebin data in N dimensions (Part 2) Add function to irregularly rebin data in N dimensions (Part 2) May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants