Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with xrayvision.visibility.Visibilities #123

Merged
merged 5 commits into from
Jun 2, 2024

Conversation

paolomassa
Copy link
Contributor

@paolomassa paolomassa commented May 31, 2024

Do not merge before TCDSolar/xrayvision/pull/67

Make the imaging demo compatible with the new xrayvision.visibility.Visibilities class. To be merged after #67.

changelog/123.feature.rst Show resolved Hide resolved
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (da09731) to head (54d4e07).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/imaging/em.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files          31       31           
  Lines        1856     1856           
=======================================
  Hits         1347     1347           
  Misses        509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney
Copy link
Member

So I think the doc build fails are because the PR on xrayvision wasn't merged. I proded the doc_build test if that passses will merge.

@samaloney samaloney merged commit 2854ed9 into TCDSolar:main Jun 2, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants