Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and test improvements #14

Merged
merged 3 commits into from
Sep 27, 2017
Merged

Clean and test improvements #14

merged 3 commits into from
Sep 27, 2017

Conversation

pgabor
Copy link
Contributor

@pgabor pgabor commented Sep 19, 2017

No description provided.

@pgabor pgabor requested a review from samaloney September 19, 2017 12:22
dirty_beam[(N-1)//2, (M-1)//2] = 1.0

dirty_map = signal.convolve2d(clean_map, dirty_beam, mode='same')

vis = Visibility(uv_in, vis_in)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use all then u, v components it is not a dirty map it's basically Fourier transform of the dirty map. If you want to do it from visibilities you need to define some subset of all the visibilities and from those do a back project to obtain the dirty map to use in line 32. So something like this

vis_in = np.zero((N, M), dtype=complex)
vis_in[(N-1)//4:(N-1)//4 + (N-1)//2, (M-1)//2] = 0.75
vis_in[(N-1)//2, (M-1)//4:(M-1)//4 + (M-1)//2, ] = 0.75
vis_in[(N-1)//2, (M-1)//2] = 1.0
vis_in = vis_in.reshap(N*M)

I'm not sure what shape uv_in is but you'd have to pick out the corresponding elements in that array as well.

@samaloney samaloney merged commit 72e166f into TCDSolar:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants