Fix bug made apparent by recent refactor #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was always a little unclear to me but now I think it makes sense. In the transform code we use/ generate
x
,y
andu
,v
. By conventionx
,u
are expected to move left/right across or in the column direction whiley
,v
move down/up vertically or in the row direction. Numpy arrays are row major, the 1st index is row 2nd is column but there was some inconsistency with applying this in the code.x
,u
are in the col direction,y
,v
in the row direction python is row, col order