Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug made apparent by recent refactor #73

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

samaloney
Copy link
Member

Was always a little unclear to me but now I think it makes sense. In the transform code we use/ generate x, y and u, v. By convention x, u are expected to move left/right across or in the column direction while y, v move down/up vertically or in the row direction. Numpy arrays are row major, the 1st index is row 2nd is column but there was some inconsistency with applying this in the code.

  • x, u are in the col direction, y, v in the row direction python is row, col order

* x, u are in the col direction, y, v in the row direction python is row, col order
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0d737e5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage        ?   89.43%           
=======================================
  Files           ?        7           
  Lines           ?      890           
  Branches        ?        0           
=======================================
  Hits            ?      796           
  Misses          ?       94           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney samaloney requested a review from paolomassa July 12, 2024 10:24
@samaloney samaloney merged commit dddf5da into TCDSolar:main Jul 16, 2024
13 checks passed
@samaloney samaloney deleted the bugfix-cart-vs-array-indices branch July 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant