Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 홈 조회에서의 schedule 데이터의 반복 쿼리 개선 #308

Open
1 task done
hoonyworld opened this issue Jan 24, 2025 · 0 comments · May be fixed by #312
Open
1 task done

[refactor] 홈 조회에서의 schedule 데이터의 반복 쿼리 개선 #308

hoonyworld opened this issue Jan 24, 2025 · 0 comments · May be fixed by #312
Assignees
@hoonyworld
Labels
enhancement performance enhancement refactor 🔁 refactor 동훈🐻

Comments

@hoonyworld
Copy link
Member

hoonyworld commented Jan 24, 2025 •
edited
Loading

Feature Issue 📌

  • 홈 조회 시, Performance 데이터 조회를 위한 1개의 쿼리와 함께, 각 Performance에 대한 Schedule 데이터를 조회하기 위해 scheduleService.getMinDueDateForPerformance()가 개별 호출되며 N번 실행되는 상황입니다.
  • 단지 Schedule 데이터의 minDueDate를 얻기 위해 N개의 추가 쿼리가 실행되고 있는 상황이기에 이를 1번의 쿼리로 가져오도록 리팩토링 합니다.

Todo ✔️

  • 홈 조회에서의 schedule 데이터의 반복 쿼리 개선
@hoonyworld hoonyworld added enhancement performance enhancement refactor 🔁 refactor 동훈🐻 labels Jan 24, 2025
@hoonyworld hoonyworld self-assigned this Jan 24, 2025
@hoonyworld hoonyworld changed the title [refactor] 홈 조회에서의 schedule 데이터의 N+1 개선 [refactor] 홈 조회에서의 schedule 데이터의 반복 쿼리 개선 Feb 24, 2025
@hoonyworld hoonyworld reopened this Feb 24, 2025
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] chore(HomeController): 변수 네이밍 변경
5b3adf2
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] fix: findAllByPerformanceId를 사용하도록 통일
2d291f7
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] refactor(ServiceLoggingAspect): 서비스 반환 로그 debug 레벨로 변경
fe7a8bc 
- 데이터가 늘어날 수록 로그가 방대하게 늘어나는 문제로 인해 debug 레벨로 변경
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] refactor: 패키지 이동
5e96bda
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] chore: 패키지 이동으로 인한 import문 변동
0b2a3f4
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] feat: 1번의 쿼리로 여러 개의 performance_id의 최소 performance_date를 가져오도록…
ebff0a6 
… 로직 구현
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] feat(MinPerformanceDateDto) 특정 공연의 최소 공연일 조회를 위한 MinPerformanc…
2c62d53 
…eDateDto 추가

- QueryDSL의 `@QueryProjection`을 활용하여 생성자를 통해 필드를 초기화할 수 있도록 설계
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] feat(MinPerformanceDateResponse): 공연 ID와 최소 공연 날짜를 매핑한 `perfor…
da1080c 
…manceDateMap`을 담는 DTO 생성
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] feat(ScheduleService): 주어진 공연 ID 목록에 대한 최소 공연 날짜를 조회하는 메서드 구현
a535966
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] refactor(HomeService): 홈 조회 메서드 리팩토링
8a940e0
@hoonyworld hoonyworld linked a pull request Feb 24, 2025 that will close this issue
Open
hoonyworld added a commit that referenced this issue Feb 24, 2025
@hoonyworld
[#308] fix(ScheduleRepositoryCustomImpl): 변수 네이밍 수정
6fb95ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoonyworld hoonyworld

Labels
enhancement performance enhancement refactor 🔁 refactor 동훈🐻
Projects
None yet
Milestone
No milestone
1 participant
@hoonyworld