Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e gno organization deployer #1304

Merged
merged 35 commits into from
Nov 2, 2024
Merged

Conversation

MikaelVallenet
Copy link
Member

@MikaelVallenet MikaelVallenet commented Oct 14, 2024

E2E Test Organization Creation.

This PR includes some changes:

  • Update generated code for deploy organization
  • Update the deploy pkg function to make it functional
  • Handle add pkg message type in Adena Mock for test
  • Write E2E test for organization deployment

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit ac7a8bc
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/672645b36379070008f24152
😎 Deploy Preview https://deploy-preview-1304--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit ac7a8bc
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/672645b3efbc990008621c0b
😎 Deploy Preview https://deploy-preview-1304--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress/e2e/dao-creation.cy.ts Outdated Show resolved Hide resolved
@MikaelVallenet MikaelVallenet changed the title test: e2e dao deployer test: e2e gno organization deployer Oct 15, 2024
@MikaelVallenet MikaelVallenet marked this pull request as ready for review October 15, 2024 15:08
packages/utils/gno.ts Outdated Show resolved Hide resolved
@n0izn0iz
Copy link
Collaborator

this could be a good time to move dao related fields from GnoNetworkInfo type to a new NetworkFeature GnoDAOs type but we can do it in another PR

packages/utils/gnodao/deploy.ts Outdated Show resolved Hide resolved
packages/utils/gnodao/deploy.ts Outdated Show resolved Hide resolved
@n0izn0iz n0izn0iz enabled auto-merge November 2, 2024 15:11
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for a first step towards stabilizing dao feature

@n0izn0iz n0izn0iz disabled auto-merge November 2, 2024 15:12
@n0izn0iz n0izn0iz enabled auto-merge November 2, 2024 15:15
@n0izn0iz n0izn0iz disabled auto-merge November 2, 2024 15:41
@n0izn0iz n0izn0iz merged commit 3512d2d into main Nov 2, 2024
21 of 22 checks passed
@n0izn0iz n0izn0iz deleted the e2e-test-dao-creation-gno branch November 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants