-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNAP-656 Delink RDD partitions from buckets #297
Conversation
…into SNAP-656 Conflicts: core/src/main/scala/org/apache/spark/sql/store/StoreUtils.scala
Conflicts: core/src/main/scala/io/snappydata/impl/SparkShellRDDHelper.scala core/src/main/scala/org/apache/spark/sql/execution/columnar/impl/JDBCSourceAsColumnarStore.scala core/src/main/scala/org/apache/spark/sql/execution/row/RowFormatScanRDD.scala core/src/main/scala/org/apache/spark/sql/store/StoreUtils.scala store
…titionedRDD + handled redundancy cases + fixed precheckin failures
// val region = Misc.getRegionForTable(resolvedName, true). | ||
// asInstanceOf[PartitionedRegion] | ||
// region.getTotalNumberOfBuckets | ||
val numCores = Runtime.getRuntime.availableProcessors() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is evaluated at driver node. We need to consider sever nodes. Driver node num processors is not useful to us. Can you please see SchedulerBackend.defaultParallelism. That takes total cores for slaves into consideration.
Catch however is spark.default.parallelism gets priority and if somebody configures bad we will suffer.
} | ||
} | ||
|
||
def getNumPartitions : Int = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
Conflicts: core/src/main/scala/org/apache/spark/sql/collection/Utils.scala core/src/main/scala/org/apache/spark/sql/execution/columnar/impl/JDBCSourceAsColumnarStore.scala core/src/main/scala/org/apache/spark/sql/store/StoreUtils.scala store
Conflicts: core/src/main/scala/org/apache/spark/sql/execution/columnar/impl/ColumnFormatRelation.scala
…fle exchange operation Use spark.default.parallelism to decide numPartitions and disabled split mode optimization
Conflicts: core/src/main/scala/org/apache/spark/sql/execution/ExistingPlans.scala store
…into SNAP-656 Conflicts: core/src/main/scala/org/apache/spark/sql/store/StoreUtils.scala store
Conflicts: store
…rStorePartitionedRDD in split mode.
Conflicts: spark store
Changes proposed in this pull request
Patch testing
ReleaseNotes.txt changes
yes
Other PRs
Store - TIBCOSoftware/snappy-store#85
Spark - TIBCOSoftware/snappy-spark#4
SnppyData - #297