Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination information and make display configurable via settings. #1159

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

davner
Copy link
Contributor

@davner davner commented Jan 23, 2025

  • Add SHOW_PAGINATION_INFO setting to toggle display of pagination info.
  • Update template and context overriding bootstrap4 templatetag.

Addresses #949

- Add SHOW_PAGINATION_INFO setting to toggle display of pagination info.
- Update template and context overriding bootstrap4 templatetag.
@davner davner force-pushed the enhancement/pagination branch from 4a08b21 to 76aff85 Compare January 23, 2025 22:31
@jchate6 jchate6 self-requested a review January 23, 2025 22:45
@davner
Copy link
Contributor Author

davner commented Jan 24, 2025

@jchate6 I realized I used numpy formatting for doc strings, would you like me to change it to match your formatting style?

Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made a few style and formatting changes.
Take a look at the last few commits if you want and let me know what you think.
Otherwise I'll probably merge this by Friday.

@davner
Copy link
Contributor Author

davner commented Jan 30, 2025

@jchate6 Just confirming, are the numpy docstring style and type hints good for you? Everything else looks great!

@jchate6
Copy link
Contributor

jchate6 commented Jan 30, 2025

@jchate6 Just confirming, are the numpy docstring style and type hints good for you? Everything else looks great!

Yes, the docstrings look good. We are attempting consistency in the existance of docstrings. We'll worry about formatting consistency later :P

@jchate6 jchate6 merged commit 519cb37 into TOMToolkit:dev Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged (to dev)
Development

Successfully merging this pull request may close these issues.

2 participants