Simplify and Modernize installation by using integration points, Poetry, and removing tom_registration_base #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
This was
linked to
issues
Jan 22, 2025
Closed
3 tasks
jchate6
changed the title
phycodurus
approved these changes
Jan 27, 2025
| @@ -21,6 +22,7 @@ class OpenRegistrationView(CreateView): | |||
| template_name = 'tom_registration/register_user.html' | |||
| success_url = reverse_lazy(settings.TOM_REGISTRATION.get('REGISTRATION_REDIRECT_PATTERN', '')) | |||
| form_class = OpenRegistrationForm | |||
| extra_context = {'version': __version__} | |||
There was a problem hiding this comment.
nice -- I didn't know you could add to the context this way. Now I see it
| BASE_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), APP_NAME)) | ||
|
|
||
|
|
||
| def boot_django(): |
jchate6
changed the base branch from
dev
to
7-revisit-and-revamp-tom-registration
jchate6
merged commit 6cddd64
into
7-revisit-and-revamp-tom-registration
2 of 18 checks passed
jchate6
deleted the
10-simplify-installation-by-using-integration-points
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is purely about streamlining and modernizing installation.
Actual function and registration are not completed yet, thus the currently failing tests.
This requires: