Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stephan/refactor/operation #626

Closed
wants to merge 2 commits into from
Closed

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Oct 22, 2024

Which issue(s) this PR fixes

Fixes None

Additional comments

Collection_name is now no longer optional in Operation class.

Agreements

@SteBaum SteBaum requested a review from PaulFarault October 22, 2024 10:51
@SteBaum SteBaum self-assigned this Oct 22, 2024
@SteBaum SteBaum force-pushed the stephan/refactor/operation branch from 190855c to a062f41 Compare October 22, 2024 10:54
@SteBaum SteBaum force-pushed the stephan/refactor/operation branch from a062f41 to 482934e Compare October 22, 2024 11:04
@SteBaum
Copy link
Contributor Author

SteBaum commented Oct 22, 2024

Finally too complicated. The Operation class will be modified to not take the collection_name to simplify the code.

@SteBaum SteBaum closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant