Shop: Backend rework 3/X #1315
Merged
Shop: Backend rework 3/X #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
reviewed
Jan 23, 2024
saibotk
requested changes
Jan 30, 2024
ZenBre4ker
commented
Jan 30, 2024
There was a problem hiding this comment.
Generally would be nice to have an opinion from both of you @Histalek @saibotk about naming convention concerning equipmentId.
Generally why have Id, name and classname if they are the same.
https://github.com/TTT-2/TTT2/blob/master/gamemodes/terrortown/gamemode/shared/sh_equip_items.lua#L59-L69
TimGoll
approved these changes
Feb 4, 2024
saibotk
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time I removed global BuyTables and moved them to proper getter and setter.
Should enable future UI to more easily check those separately.