Added Win Score Event #1733
Added Win Score Event #1733
Conversation
Added a win score for winning and a matching LANG entry and score parameter in the role base
There was a problem hiding this comment.
I personally do like this. TTT handled winning differently. Each surviving player from a team gave a bonus. That way you were awarded for winning and keeping your team mates alive.
But since TTT2 puts a bigger focus on different teams, I think this change is valid. In general I'm all for adding more events that give score points (like a single point for the first person to call a dete to a corpse) to emphasis beneficial actions.
Before merging I think that @Histalek and @saibotk should give their opinion on this as well
|
I'd recommend making feature branch for each PR you do, that way you make sure that old commits are no longer listed in the changelog. Alternatively you could sync your fork before adding new commits. |
In #1733 I said in a review comment that the fallback can be removed here: #1733 (comment) However, this was not true. I misread the context of the code. This caused the issue reported in #1744.
Added win score to finish event with parameter for amount of score in role base and LANG entries I felt like it was weird that no score was gained for winning, especially for roles that cant gain score as quickly in other ways. This adds an event for that where score amount can also be configured for every role.
In TTT-2#1733 I said in a review comment that the fallback can be removed here: TTT-2#1733 (comment) However, this was not true. I misread the context of the code. This caused the issue reported in TTT-2#1744.
Added win score to finish event with parameter for amount of score in role base and LANG entries
I felt like it was weird that no score was gained for winning, especially for roles that cant gain score as quickly in other ways. This adds an event for that where score amount can also be configured for every role.