Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 Equipment Settings #1765

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Spanospy
Copy link
Contributor

@Spanospy Spanospy commented Feb 12, 2025

Works towards #1729

Tested on a local server however getting this error that I can't fix without stepping on someone else's toes:
image
@MrXonte Could you advise?

@MrXonte
Copy link
Contributor

MrXonte commented Feb 12, 2025

It looks like the initialization of the InnerRadius on the Clientside failed somehow, which is weird since you are using fallback values.
Does the serverside stuff work correctly (aka the explosion) because it also uses those parameters. If it works and only the markervision throws errors, then it's a problem with clientside initialization.

@Spanospy
Copy link
Contributor Author

Thanks for pointing out my mistakes figardo - I'll fix them when I get home tonight.

@Spanospy
Copy link
Contributor Author

Tested with fix and all looks fine. Didn't extensively experiment with the damage scaling but I can confirm it retrieves the value correctly.

I'll sort out some translations & changelog now.

@MrXonte
Copy link
Contributor

MrXonte commented Feb 12, 2025

Tested with fix and all looks fine. Didn't extensively experiment with the damage scaling but I can confirm it retrieves the value correctly.

I'll sort out some translations & changelog now.

To be close to base ttt c4 you likely also need to decrease default damage to 125 and innerradius to 490 (for me 500 is fine too). Those values are from the base c4. The 0 damage dropoff was at exactly 601.18 aka (490+sqrt(12500)) units, so 600 should be fine

@Spanospy
Copy link
Contributor Author

To be close to base ttt c4 you likely also need to decrease default damage to 125

That's what base TTT uses for its deadly spheredamage, though the blast damage that also happens is 200.

Right now, TTT2 uses the same value for both ExplosiveSphereDamage's damage and env_physexplosion's magnitude

@Spanospy
Copy link
Contributor Author

Spanospy commented Feb 13, 2025

Just realising that env_physexplosion does not do any damage - merely pushes stuff around.

What I actually meant to say was that TTT2 uses the same damage value for ExplosiveSphereDamage, Explosion effect and HelicopterMegaBomb effect.

I'm wondering if we want to replicate the TTT damage values by multiplying the damage used for ExplosiveSphereDamage by 0.625. Thoughts?

@Spanospy Spanospy marked this pull request as ready for review February 13, 2025 01:12
@MrXonte
Copy link
Contributor

MrXonte commented Feb 13, 2025 via email

@Spanospy
Copy link
Contributor Author

Gotcha. Damage values can be a different issue / PR - this PR helps to customise damage anyway.

@wgetJane
Copy link
Contributor

wgetJane commented Feb 17, 2025

might be out of scope of this pr, but can you add min and max settings for the timer as well

@Spanospy
Copy link
Contributor Author

Spanospy commented Feb 17, 2025

might be out of scope of this pr as well, but can you add min and max settings for the timer as well

Personally I think that's already partially built into the C4 itself, as users can set the desired time up to 10 minutes.

Granted, 10 minutes is a silly value to set the C4 timer to most of the time. Perhaps it would be a good idea for server admins to reduce user error by adjusting max time.

Similarly, may be an argument for admins to be able to adjust the minimum timer amount if 45 seconds is considered too low or too high for the server.

@Spanospy
Copy link
Contributor Author

Placing 10 minute C4 in the middle of an open area is a funny meme though!

@wgetJane
Copy link
Contributor

yeah i guess it makes more sense to only be able to change the min timer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants