Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore errors in validation framework, use new ISMN interface in tests #260

Closed
wants to merge 16 commits into from

Conversation

wpreimes
Copy link
Member

Option to ignore errors in validation framework, use new ismn interface in tests, fix binary incompatibilities using oldest-supported-numpy, drop py 3.6 (as this is not supported by latest pytest and other dependencies).

@wpreimes wpreimes requested a review from s-scherrer January 12, 2022 00:31
@wpreimes
Copy link
Member Author

I should split this up into at least 2 PRs... will do that. @s-scherrer but to fix the pip install I think really only https://github.com/wpreimes/pytesmo/blob/master/pyproject.toml#L2 is relevant.

@wpreimes wpreimes marked this pull request as draft January 12, 2022 07:22
@sebhahn
Copy link
Member

sebhahn commented Jan 12, 2022

Does it mean the next pytesmo version will be >= py 3.7?

@s-scherrer
Copy link
Collaborator

I should split this up into at least 2 PRs... will do that. @s-scherrer but to fix the pip install I think really only https://github.com/wpreimes/pytesmo/blob/master/pyproject.toml#L2 is relevant.

Super, thanks a lot for fixing this!

@wpreimes
Copy link
Member Author

Does it mean the next pytesmo version will be >= py 3.7?

from 0.14 on yes, to fix the pip installation I would release 0.13.4 with python 3.6 as well

@sebhahn
Copy link
Member

sebhahn commented Jan 12, 2022

would pip install work if pytest is pinned?

@wpreimes wpreimes changed the title Fix pip install Option to ignore errors in validation framework, use new ISMN interface in tests Jan 12, 2022
@wpreimes
Copy link
Member Author

as long as pip does not run into version conflicts (with packages defined in setup.cfg) it should still work with old python versions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants