Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for Symfony v7 components #119

Merged
merged 9 commits into from
Jan 31, 2024
Merged

[FEATURE] Add support for Symfony v7 components #119

merged 9 commits into from
Jan 31, 2024

Conversation

eliashaeussler
Copy link
Contributor

This PR extends version constraints to support Symfony v7 components. In addition, the overtrue/phplint package was updated to a more recent version that supports Symfony v7 as well.

Next to the version constraint updates, the following code modifications were necessary:

  • Run console commands without ANSI colors during testing by using the --no-ansi command option
  • Replace removed Helper::strlenWithoutDecoration() with Helper::removeDecoration()
  • Add parameter types and return types to SimpleStyle
  • Avoid using defaultName and defaultDescription properties in console commands

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request maintenance labels Jan 18, 2024
composer.json Outdated Show resolved Hide resolved
@eliashaeussler
Copy link
Contributor Author

@bmack I think it would be great to merge #122 first. This would allow us to test with Symfony v7 against PHP 8.3 as well.

@bmack bmack merged commit e0a8f70 into TYPO3:main Jan 31, 2024
54 of 57 checks passed
@bmack
Copy link
Member

bmack commented Jan 31, 2024

thank you. once CI is green, I will create a new release

@eliashaeussler eliashaeussler deleted the feature/symfony-v7 branch January 31, 2024 07:17
@eliashaeussler
Copy link
Contributor Author

Thank you for the merge, Benni! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants