Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Avoid yoda-style conditions in PHP #31

Merged
merged 2 commits into from
Jul 1, 2022
Merged

[BUGFIX] Avoid yoda-style conditions in PHP #31

merged 2 commits into from
Jul 1, 2022

Conversation

eliashaeussler
Copy link
Contributor

This commit streamlines the PHP-CS-Fixer rules with TYPO3/typo3@0fb53e0 which added configuration to disable yoda-style conditions.

@eliashaeussler
[BUGFIX] Avoid yoda-style conditions in PHP
5e0ff53 
This commit streamlines the PHP-CS-Fixer rules with TYPO3/typo3@0fb53e0
which added configuration to disable yoda-style conditions.
@mbrodala mbrodala mentioned this pull request Jul 1, 2022
Closed
@mbrodala
Copy link
Contributor

mbrodala commented Jul 1, 2022

Can you update the failing CsFixerConfigTest?

@mbrodala mbrodala mentioned this pull request Jul 1, 2022
Merged
@gilbertsoft gilbertsoft merged commit 8ec5562 into TYPO3:main Jul 1, 2022
@gilbertsoft
Copy link
Collaborator

Thanks!

@eliashaeussler eliashaeussler deleted the bugfix/yoda-style branch July 1, 2022 16:33
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Jul 6, 2022
@dkd-kaehm
[BUGFIX] Avoid yoda-style conditions in PHP
f3820df 
Follow-Up for:
* TYPO3/typo3@0fb53e0
* TYPO3/coding-standards#31
@dkd-kaehm dkd-kaehm mentioned this pull request Jul 6, 2022
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Jul 6, 2022
@dkd-kaehm
[BUGFIX] Avoid yoda-style conditions in PHP
ac80f3a 
Follow-Up for:
* TYPO3/typo3@0fb53e0
* TYPO3/coding-standards#31
@dkd-kaehm dkd-kaehm mentioned this pull request Jul 6, 2022
Merged
dkd-kaehm added a commit to TYPO3-Solr/ext-solr that referenced this pull request Jul 6, 2022
@dkd-kaehm
[BUGFIX] Avoid yoda-style conditions in PHP
82a1592 
Follow-Up for:
* TYPO3/typo3@0fb53e0
* TYPO3/coding-standards#31
dkd-kaehm added a commit to TYPO3-Solr/ext-solr that referenced this pull request Jul 6, 2022
@dkd-kaehm
[BUGFIX] Avoid yoda-style conditions in PHP
48e52db 
Follow-Up for:
* TYPO3/typo3@0fb53e0
* TYPO3/coding-standards#31
dkd-kaehm added a commit to TYPO3-Solr/ext-solr that referenced this pull request Jul 6, 2022
@dkd-kaehm
[BUGFIX] Avoid yoda-style conditions in PHP
fb7dc63 
Follow-Up for:
* TYPO3/typo3@0fb53e0
* TYPO3/coding-standards#31
@eliashaeussler eliashaeussler mentioned this pull request Jul 20, 2022
Merged
@gilbertsoft gilbertsoft added bug Something isn't working maintenance labels Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliashaeussler @mbrodala @gilbertsoft @oliverklee