[TASK] Backport library to support PHP 7.0 and 7.1 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienast
force-pushed
the
bugfix/compat-php-70
branch
2 times, most recently
from
7c772eb to
03aa925
Compare
ohader
reviewed
Dec 6, 2022
|
The title of this PR and commits should not be |
The PHP code of this library is backported to additionally support both PHP 7.0 and PHP 7.1. In order to achieve this, const visibility, nullable types and `void` types were removed and replaced with PHPDoc comments where applicable.
andreaskienast
force-pushed
the
bugfix/compat-php-70
branch
from
03aa925 to
9406c88
Compare
andreaskienast
changed the title
ohader
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP code of this library is backported to additionally support both PHP 7.0 and PHP 7.1.
In order to achieve this, const visibility, nullable types and
voidtypes were removed and replaced with PHPDoc comments where applicable.