feat(vscode): add at feature with AT file implementation in VSCode #3602
+121
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sma1lboy
force-pushed
the
feat-at-function-vscode
branch
from
5244117 to
ccad4a3
Compare
Sma1lboy
changed the title
icycodes
requested changes
Jan 6, 2025
Comment on lines
+228
to
+239
| let label: string; | ||
|
|
||
| if (filepath.kind === "git") { | ||
| label = filepath.filepath; | ||
| } else { | ||
| const workspaceFolder = workspace.getWorkspaceFolder(uri); | ||
| if (workspaceFolder) { | ||
| label = path.relative(workspaceFolder.uri.fsPath, uri.fsPath); | ||
| } else { | ||
| label = path.basename(uri.fsPath); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please try to use method workspace.asRelativePath:
Suggested change
| let label: string; | |
| if (filepath.kind === "git") { | |
| label = filepath.filepath; | |
| } else { | |
| const workspaceFolder = workspace.getWorkspaceFolder(uri); | |
| if (workspaceFolder) { | |
| label = path.relative(workspaceFolder.uri.fsPath, uri.fsPath); | |
| } else { | |
| label = path.basename(uri.fsPath); | |
| } | |
| } | |
| const label = worksapce.asRelativePath(uri); |
Comment on lines
+247
to
+270
| export function extractTextFromRange(document: TextDocument, range: LineRange | PositionRange): string { | ||
| if (typeof range.start === "number" && typeof range.end === "number") { | ||
| const startLine = range.start - 1; | ||
| const endLine = range.end - 1; | ||
| let selectedText = ""; | ||
|
|
||
| for (let i = startLine; i <= endLine; i++) { | ||
| if (i < 0 || i >= document.lineCount) { | ||
| continue; | ||
| } | ||
| selectedText += document.lineAt(i).text + "\n"; | ||
| } | ||
| return selectedText; | ||
| } | ||
|
|
||
| if (typeof range.start === "object" && typeof range.end === "object") { | ||
| const startPos = new VSCodePosition(range.start.line - 1, range.start.character - 1); | ||
| const endPos = new VSCodePosition(range.end.line - 1, range.end.character - 1); | ||
| const selectedRange = new VSCodeRange(startPos, endPos); | ||
| return document.getText(selectedRange); | ||
| } | ||
|
|
||
| return ""; | ||
| } |
There was a problem hiding this comment.
Can we reuse chatPanelLocationToVSCodeRange to convert range: LineRange | PositionRange to VSCodeRange?
By reusing thiat, there is no need to extract extractTextFromRange.
| this.logger.info(`No query provided, listing ${openTabs.length} opened editors.`); | ||
|
|
||
| return openTabs | ||
| .filter((tab) => tab.uri.scheme === "file") |
Comment on lines
+475
to
+478
| .map((tab) => ({ | ||
| uri: (tab.input as TabInputText).uri, | ||
| label: tab.label, | ||
| })), |
There was a problem hiding this comment.
I think this map is not required here. You can directly map it with uriToListFileItem.
| .map((tab) => uriToListFileItem(tab.uri, this.gitProvider)); | ||
| } | ||
|
|
||
| const globPattern = `**/${query}*`; |
There was a problem hiding this comment.
Should we validate the query string before injecting it into the glob pattern to ensure **/${query}* is safe? For example, what if the query string contains * or other special characters?
| }, | ||
|
|
||
| readFileContent: async (info: FileRange): Promise<string | null> => { | ||
| if (info.range) { |
There was a problem hiding this comment.
There's no need for an if branch here. document.getText() can accept a range or undefined as parameters.
Comment on lines
+511
to
+514
| } catch (error) { | ||
| this.logger.error("Failed to get file content by range:", error); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
No need to catch error, or just rethrow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not git repo
in git repo