feat(vscode): add shortcut hint in codeLens title #3637
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antimonyGu
commented
Dec 31, 2024
•
antimonyGu
commented
- Recording: https://jam.dev/c/97d046de-ee6f-42b5-8bef-06dfbbd934d0.
- To do: Read keybinds from LSP client.
|
Please consider implementing this in the VSCode scope first. This will avoid adding an API to the Tabby-agent protocol. You can try adding the processing in CodeLensMiddleware.ts to modify the CodeLens title. |
antimonyGu
changed the title
antimonyGu
force-pushed
the
add-shortcur-for-accept
branch
from
73a5a83 to
bb0aedd
Compare
icycodes
requested changes
Jan 6, 2025
Comment on lines
+78
to
+86
|
|
||
| if (!codeLenses) { | ||
| return []; | ||
| } | ||
|
|
||
| this.removeDecorations(editor); | ||
| const result = | ||
| codeLenses | ||
| ?.map((codeLens) => this.handleCodeLens(codeLens, editor)) | ||
| .filter((codeLens): codeLens is CodeLens => codeLens !== null) ?? []; | ||
| const result = codeLenses | ||
| .map((codeLens) => this.handleCodeLens(codeLens, editor)) | ||
| .filter((codeLens): codeLens is CodeLens => codeLens !== null); |
There was a problem hiding this comment.
Is this change necessary? This change will prevent this.removeDecorations(editor) from being invoked when codelenses is empty.
| @@ -106,6 +112,19 @@ export class CodeLensMiddleware implements VscodeLspCodeLensMiddleware { | |||
| return null; | |||
| } | |||
|
|
|||
| private addShortcut(codeLens: CodeLens) { | |||
| if (codeLens.command?.arguments?.[0].action === "accept") { | |||
| // TODO: read ~/.config/Code/User/keybindings.json from LSP client, then send to LSP server to avoid hardcode. | |||
There was a problem hiding this comment.
Suggested change
| // TODO: read ~/.config/Code/User/keybindings.json from LSP client, then send to LSP server to avoid hardcode. | |
| // FIXME: Read the user keybinding config to check if there is a customized keybinding. |
| private addShortcut(codeLens: CodeLens) { | ||
| if (codeLens.command?.arguments?.[0].action === "accept") { | ||
| // TODO: read ~/.config/Code/User/keybindings.json from LSP client, then send to LSP server to avoid hardcode. | ||
| const acceptShortcut = isBrowser ? "" : ` (${process.platform === "darwin" ? "cmd+enter" : "ctrl+enter"})`; |
There was a problem hiding this comment.
Please keep the keybinding hint label consistent with VSCode's style.
- On Linux/Windows,
Ctrl+Entershould be capitalized. - On macOS, Unicode symbols like
⌘should be used.
Please refer to the VSCode source for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.