Unconfirm unexpected feedback based on prefs

If teams are only expected to submit feedback on the orallist, if there
are multiple submissions from the same debate team to different adjs,
there is a problem. The feedback should then be unconfirmed as to not
affect the scores of unexpected adjs.

Fixes #473

tabbycat/adjfeedback/models.py

@@ -254,6 +254,12 @@ def __str__(self):
             time=('<unknown>' if self.timestamp is None else str(
                 self.timestamp.isoformat())))
 
+    def _unique_unconfirm_args(self):
+        kwargs = super()._unique_unconfirm_args()
+        if self.source_team is not None and self.source_team.debate.round.tournament.pref('feedback_from_teams') != 'all-adjs':
+            kwargs.pop('adjudicator')
+        return kwargs
+
     @cached_property
     def source(self):
         if self.source_adjudicator:

tabbycat/results/models.py

@@ -69,6 +69,9 @@ def _unique_filter_args(self):
         return dict((arg, getattr(self, arg)) for arg in self._meta.unique_together[0]
                     if arg != 'version')
 
+    def _unique_unconfirm_args(self):
+        return self._unique_filter_args
+
     def save(self, *args, **kwargs):
         # Use a lock to protect against the possibility that two submissions do this
         # at the same time and get the same version number or both be confirmed.
@@ -85,7 +88,7 @@ def save(self, *args, **kwargs):
             # Check for uniqueness.
             if self.confirmed:
                 unconfirmed = self.__class__.objects.filter(confirmed=True,
-                        **self._unique_filter_args).exclude(pk=self.pk).update(confirmed=False)
+                        **self._unique_unconfirm_args()).exclude(pk=self.pk).update(confirmed=False)
                 if unconfirmed > 0:
                     logger.info("Unconfirmed %d %s so that %s could be confirmed", unconfirmed, self._meta.verbose_name_plural, self)