Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public ballot submissions should save which adjudicator's link was used #683

Closed
czlee opened this issue Jul 9, 2018 · 2 comments · Fixed by #1586
Closed

Public ballot submissions should save which adjudicator's link was used #683

czlee opened this issue Jul 9, 2018 · 2 comments · Fixed by #1586

Comments

@czlee
Copy link
Member

czlee commented Jul 9, 2018

Kind of funny that we haven't thought of this before now, but at the moment it just saves IP address, given that private URLs are the norm it probably makes sense to take note of which adjudicator's URL was used to submit the ballot.

(Doesn't make so much sense for feedback since that's effectively already done.)

@tienne-B
Copy link
Member

tienne-B commented Jul 20, 2018

Should this issue be extended to cover feedback forms with the migration of url_key towards Person and not just Adjudicator? Because then it isn't a Team submission, but a Speaker representing the Team.

@czlee
Copy link
Member Author

czlee commented Jul 20, 2018

In principle yes, though I think the better thing to do is park this till we've figured out #684. It might just be that this whole issue becomes obsolete as a result of the restructure to support notifications and logging of participant actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants