Expand boolean variables within 'with' statement #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'with' templatetag does not seem to support boolean operators, as were used for team registration cards. This commit expands these vars where used, keeping in mind Django's precedence. Fixes BACKEND-3CH.
|
Sentry issue: BACKEND-3CH |
|
rip, how did we miss this? fwiw I actually prefer this anyway, I think it's clearer than with the |
|
I much prefer the |
|
Sentry issue: BACKEND-3CJ |
|
Merging, there are still some outstanding edge cases to clean up but this fixes the crash issue so merging to roll out in hotfix 2.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'with' templatetag does not seem to support boolean operators, as
were used for team registration cards. This commit expands these vars
where used, keeping in mind Django's precedence.
Fixes BACKEND-3CH.