Re-implement debate postponement #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If postponements are disabled (which they are by default, and are not yet implemented), the drop-down for the debate status should not show the option. Currently, choosing that option causes an error. This commit checks for the new preference and adapts the options to that. The new preference re-uses the old text for the preference before deletion.
This commit re-implements the get_status_meta function to use a dict- based switch rather than if/elif statements, while adding postponements back. Further, the ValueError exception raised is replaced by the generic KeyError. Fixes BACKEND-3ET
This commit adds the postponed status to the current results statistics chart, and to the container view. However, the status could not be added to the time graph as the use of the status is not linear (can be applied before or after a ballot is submitted).
As we are only checking if 0 (or not 0), the exists() function is better.
This column is activated with the related preference, showing a button if the debate is not postponed and text stating its status if it is postponed. If a debate is postponed, we cannot determine what status it should have when un-postponed, so keeping it a string.
|
Hey, thanks for adding this. I've made a small design tweak to results form. Two things that are probably necessary to finish the PR:
|
|
Done |
|
Just noting that a regression happened in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brief, debate postponement is to signal that a ballot should get re-checked or is not vital to the creation of the next round, and so you can advance to the next round with postponed debates.
Debates can be postponed with or without a ballot; to postpone without results, each debate will have a button on the results page in order to postpone the debate. They can only be un-postponed by adding results, and in the assistant view, it is automatic. The button will work if there are results, as the status could be used to indicate that the ballot should be re-checked.
Postponing a debate activates the ballot status consumer, which updates the table, but not the postponement column.
A similar feature was previously available with divisions, but was recently removed.
Fixes #534, with this change as a necessary "guard."
Fixes #1283
Supersedes #1420
Not quite ready; want to make the table buttons update with the consumer, similarly to the icons.