Fix wrong type in annealing without initial #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the initial allocation is given by an allocator (Hungarian) if None in the method, initial could be a tuple, when it's only expecting a list of AdjudicatorAllocations. This commit ignores the warnings (second element of the allocate function), and also does some optimisations.
|
I'll defer the question of redundancy to @czlee, but I can't imagine a future use case that requires it to be maintained. |
|
Hello, sorry I'm late getting to this. I think it'd be fair to say we don't care for maintaining it. It's mostly there as a historical relic. I think @qlim might've just been experimenting with different allocation algorithms. Some other tab systems use simulated annealing. |
|
Think this emulated the original tabbie allocation algo. Don't think it was ever used at a tournament while I was maintaining! :D |
tienne-B
referenced
this pull request
Nov 2, 2020
The simulated annealing adjudicator allocator is deprecated, only available through the command line, and depends on the Hungarian allocation, making its use moot. It seems also to have never been used, just comparing algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the initial allocation is given by an allocator (Hungarian) if None in the method, initial could be a tuple, when it's only expecting a list of AdjudicatorAllocations. This commit ignores the warnings (second element of the allocate function), and also does some optimisations.
Should this allocator be outright deprecated? It was written >10 years ago without much change (other than changing the default initial to basically supersede this allocator).