Added support for Unicode 12.0 and 13.0 emoji #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienne-B
reviewed
Oct 9, 2022
tienne-B
reviewed
Oct 9, 2022
tienne-B
reviewed
Oct 9, 2022
tienne-B
approved these changes
Oct 9, 2022
|
Thank you so much. Sorry, this took a lot more effort than it should have :( |
|
Sorry to hear it wasn't as simple as expected. We'd have hoped that having the Emoji spreadsheet would make it easier as everything could be copy-pasted between Emojipedia to the spreadsheet and from there to our code. Ideas on how to improve the process? Congratulations on accomplishing it though! If you want, email us at [email protected] and we can send you some merch. |
|
No, the difficulties were fully on me, I just mostly wasn't careful enough with each of the commits to check other consequences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are now included in the spreadsheet as well as in
emoji.py. Closes #2081.