refactoring: centralize field IDs #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedpodtrzitko
changed the title
yedpodtrzitko
force-pushed
the
yed/enum-fields
branch
from
0109b2d to
df5fa06
Compare
CyanVoxel
added
the
Type: Refactor
yedpodtrzitko
force-pushed
the
yed/enum-fields
branch
2 times, most recently
from
8567e68 to
fe59f68
Compare
Closed
yedpodtrzitko
force-pushed
the
yed/enum-fields
branch
2 times, most recently
from
c194168 to
12fa230
Compare
yedpodtrzitko
force-pushed
the
yed/enum-fields
branch
from
12fa230 to
572f242
Compare
CyanVoxel
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR puts all field IDs into one enum, and use that instead of numbers directly or ad-hoc created variables with given values.