Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate removal #410

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Fix duplicate removal #410

merged 1 commit into from
Aug 31, 2024

Conversation

Toby222
Copy link
Contributor

@Toby222 Toby222 commented Aug 28, 2024 •
edited
Loading

fix(dupes): fix duplicate file matching
chore: remove constant newline printing in file matching

@Toby222 Toby222 changed the title fix(dupes): fix duplicate file matching Fix duplicate removal Aug 28, 2024
@CyanVoxel
Copy link
Member

Looks like this was missed in the #156 pathlib refactor and has been hanging around ever since. Come to think of it I probably haven't used the duplicate removal since before that PR! Normally I would request opening an issue to explain what was fixed, but it seems pretty self explanatory here. Good catch! 👍

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended TagStudio: Library Relating to the TagStudio library system Priority: Medium An issue that shouldn't be be saved for last Status: Mergeable The code is ready to be merged labels Aug 28, 2024
@Toby222
Copy link
Contributor Author

Toby222 commented Aug 28, 2024

I couldn't think of an issue that wouldn't have had more words than the code in the PR to fix it :^)
I'm moving away from Google Photos and had to turn the album folders into tags, which this just happened to be perfect for

eivl
eivl approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@eivl eivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kaizen commit approval.

@Toby222 Toby222 closed this Aug 31, 2024
@CyanVoxel
Copy link
Member

@Toby222 Why the closure and wipe? 🤔

@CyanVoxel CyanVoxel added Type: Invalid This doesn't seem right and removed Status: Mergeable The code is ready to be merged labels Aug 31, 2024
@Toby222
Copy link
Contributor Author

Toby222 commented Aug 31, 2024 •
edited
Loading

Ooooppps, I forgot that GitHub does that
Will fix ASAP

@Toby222
fix(dupes): fix duplicate file matching
3e273cd 
chore: remove constant newline printing in file matching
@Toby222 Toby222 reopened this Aug 31, 2024
@Toby222
Copy link
Contributor Author

Toby222 commented Aug 31, 2024 •
edited
Loading

(had to rebase onto main to make GitHub let me reopen the PR ^^)

@CyanVoxel
Copy link
Member

Alright, I'll try rebasing this back to Alpha-v9.4 - it should be fine, but there's some weird git shenanigans going on...

@CyanVoxel CyanVoxel changed the base branch from main to Alpha-v9.4 August 31, 2024 19:25
@CyanVoxel CyanVoxel removed Type: Invalid This doesn't seem right Priority: Medium An issue that shouldn't be be saved for last labels Aug 31, 2024
@CyanVoxel
Copy link
Member

Ahhh now all the newer flake changes from main are in here too... I might just have to update Alpha-v9.4 from main before merging this

@CyanVoxel CyanVoxel changed the base branch from Alpha-v9.4 to main August 31, 2024 19:41
@CyanVoxel CyanVoxel changed the base branch from main to Alpha-v9.4 August 31, 2024 19:41
@CyanVoxel CyanVoxel merged commit d8ef543 into TagStudioDev:Alpha-v9.4 Aug 31, 2024
8 checks passed
@Toby222
Copy link
Contributor Author

Toby222 commented Sep 1, 2024

git shenanigans ^^;
Yea my bad but it works:tm:

CarterPillow pushed a commit to CarterPillow/TagStudio that referenced this pull request Sep 7, 2024
@Toby222 @CarterPillow
fix(dupes): fix duplicate file matching (TagStudioDev#410)
2c739ca 
chore: remove constant newline printing in file matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivl eivl eivl approved these changes

Assignees
No one assigned
Labels
TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toby222 @CyanVoxel @eivl