Add en.json with strings found in code #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Refactor
Closed
This removes any string tokens for unused/unfinished features, internally facing code, and log outputs.
| "build_tags.parent_tags": "Parent Tags", | ||
| "build_tags.add_parent_tags": "Add Parent Tags", | ||
| "delete_unlinked.delete_unlinked": "Delete Unlinked Entries", | ||
| "delete_unlinked.confirm": "Are you sure you want to delete the following %{len(self.lib.missing_files)} entries?", |
There was a problem hiding this comment.
@Bamowen if the underlying implementation changes (for example from variable self.lib.missing_files to missing_files_count), will it break the translation? If so, then that's quite brittle way how to make these translation string.
In such case it would be better to change the strings in code from f-string to use format() like this:
"Are you (...) {files_count} entries?".format(files_count=len(self.lib.missing_files)), so the translation is not directly coupled to the variable name.
There was a problem hiding this comment.
I've been doing this in #447 as I go through changing the code
seakrueger
pushed a commit
to seakrueger/TagStudio
that referenced
this pull request
Sep 28, 2024
* Add en.json with strings found in code * remove unused, internal, and logging strings This removes any string tokens for unused/unfinished features, internally facing code, and log outputs. --------- Co-authored-by: Travis Abendshien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file compiles all strings found in the code in one json.
Surely I've missed some, but this should be a good enough start for the translation effort.