-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pdf thumbnail support (port #378) #543
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8060c9d
feat: add pdf thumbnail support
CyanVoxel 1f21cbc
fix: remove redef
CyanVoxel 32641bd
tests: add test comparing pdf to png snapshot
CyanVoxel a158adc
fix: fix info in docstrings
CyanVoxel 5e22be3
fix: remove sample png generation
CyanVoxel 8ad055a
Merge branch 'main' into pdf-thumbs
CyanVoxel 45a12f2
fix: change the pdf snapshot to use a black square
CyanVoxel 5ca7a23
Merge branch 'main' into pdf-thumbs
CyanVoxel 66b3a05
chore: fix whitespace
CyanVoxel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Copyright (C) 2024 Travis Abendshien (CyanVoxel). | ||
# Licensed under the GPL-3.0 License. | ||
# Created for TagStudio: https://github.com/CyanVoxel/TagStudio | ||
|
||
import numpy as np | ||
from PIL import Image | ||
|
||
|
||
def replace_transparent_pixels( | ||
img: Image.Image, color: tuple[int, int, int, int] = (255, 255, 255, 255) | ||
) -> Image.Image: | ||
"""Replace (copying/without mutating) all transparent pixels in an image with the color. | ||
|
||
Args: | ||
img (Image.Image): | ||
The source image | ||
color (tuple[int, int, int, int]): | ||
The color (RGBA, 0 to 255) which transparent pixels should be set to. | ||
Defaults to white (255, 255, 255, 255) | ||
|
||
Returns: | ||
Image.Image: | ||
A copy of img with the pixels replaced. | ||
""" | ||
pixel_array = np.asarray(img.convert("RGBA")).copy() | ||
pixel_array[pixel_array[:, :, 3] == 0] = color | ||
return Image.fromarray(pixel_array) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file added
BIN
+1.82 KB
tagstudio/tests/qt/__snapshots__/test_thumb_renderer/test_pdf_preview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to have a test for this. Rather than explaining what and how, I made the test, so feel free to cherry-pick/merge it into the branch. But it looks like the final png isnt really transparent 🤔
b1bae1f