[9.4.x] Create auto-backup of library for use in save failures (Fix #343) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Priority: Critical
CyanVoxel
removed
the
Priority: Critical
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic library autosave feature which creates a copy of the library on load which can be automatically loaded in the event that the main library becomes blank or missing. In addition, this moves the
self.to_json()call inside the library save method to outside of thewithblock as suggested in #343, which should prevent most cases of TagStudio writing a blank library to disk.I'm looking at this as a bugfix to be added in a future 9.4.2 patch. Since 9.5/main uses a completely different SQLite backend, this change is really just to provide a bit more safety and stability for the current 9.4.x releases in the meantime. This "feature" will die with that branch and is effectively obsolete as-is (not to sound somber).