Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make path search use globs #582

Merged
merged 4 commits into from
Nov 14, 2024
Merged

feat: make path search use globs #582

merged 4 commits into from
Nov 14, 2024

Conversation

python357-1
Copy link
Collaborator

Implements the alternative searching mentioned in #577

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request TagStudio: Search The TagStudio search engine Status: Review Needed A review of this is needed labels Nov 11, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Nov 12, 2024
CyanVoxel
CyanVoxel approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The only comment I have would be to add support for quotes, but that's included with #575 so it's effectively taken care of. Thank you for this!

@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Nov 14, 2024
@CyanVoxel CyanVoxel merged commit fd0df94 into TagStudioDev:main Nov 14, 2024
5 checks passed
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Nov 14, 2024
@CyanVoxel CyanVoxel mentioned this pull request Nov 15, 2024
Closed
3 tasks
@CyanVoxel CyanVoxel mentioned this pull request Dec 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees
No one assigned
Labels
TagStudio: Search The TagStudio search engine Type: Enhancement New feature or request
Projects
TagStudio Development
Status: ✅ Done
Milestone
Alpha v9.5 (Post-SQL)
Development

Successfully merging this pull request may close these issues.
2 participants
@python357-1 @CyanVoxel